From 52f083583b69d4e4dc5f80c277ab98bc97a16a52 Mon Sep 17 00:00:00 2001 From: Pyrbu Date: Tue, 25 Jul 2023 03:14:41 +0200 Subject: [PATCH] update viewers list before showing the npc to prevent the show/hide methods from being called multiple times by the processor task when the method needs extra time to grab skins which causes some problems including multiple teams being created resulting in client warnings/kicks on BungeeCord --- plugin/src/main/java/lol/pyr/znpcsplus/util/Viewable.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugin/src/main/java/lol/pyr/znpcsplus/util/Viewable.java b/plugin/src/main/java/lol/pyr/znpcsplus/util/Viewable.java index 8bd8f56..2670ae4 100644 --- a/plugin/src/main/java/lol/pyr/znpcsplus/util/Viewable.java +++ b/plugin/src/main/java/lol/pyr/znpcsplus/util/Viewable.java @@ -27,14 +27,14 @@ public abstract class Viewable { public void show(Player player) { if (viewers.contains(player)) return; - UNSAFE_show(player); viewers.add(player); + UNSAFE_show(player); } public void hide(Player player) { if (!viewers.contains(player)) return; - UNSAFE_hide(player); viewers.remove(player); + UNSAFE_hide(player); } public boolean isShown(Player player) {