From 14ff80b3efc4802f7112b652d3b8b798c1e02837 Mon Sep 17 00:00:00 2001
From: D3v1s0m <49519439+D3v1s0m@users.noreply.github.com>
Date: Sun, 21 May 2023 08:48:28 +0530
Subject: [PATCH] changed load order - fixes plugin not loading at all

---
 .../java/lol/pyr/znpcsplus/ZNpcsPlus.java     | 23 +++++++++++--------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/plugin/src/main/java/lol/pyr/znpcsplus/ZNpcsPlus.java b/plugin/src/main/java/lol/pyr/znpcsplus/ZNpcsPlus.java
index 750a0f4..58280d0 100644
--- a/plugin/src/main/java/lol/pyr/znpcsplus/ZNpcsPlus.java
+++ b/plugin/src/main/java/lol/pyr/znpcsplus/ZNpcsPlus.java
@@ -110,10 +110,6 @@ public class ZNpcsPlus extends JavaPlugin implements ZApi {
         log(ChatColor.WHITE + " * Initializing Adventure...");
         adventure = BukkitAudiences.create(this);
 
-        log(ChatColor.WHITE + " * Initializing PacketEvents...");
-        packetEvents.getEventManager().registerListener(new InteractionPacketListener(userManager, npcRegistry), PacketListenerPriority.MONITOR);
-        packetEvents.init();
-
         metadataFactory = setupMetadataFactory();
         PacketFactory packetFactory = setupPacketFactory();
 
@@ -125,20 +121,15 @@ public class ZNpcsPlus extends JavaPlugin implements ZApi {
         log(ChatColor.WHITE + " * Defining NPC types...");
         NpcTypeImpl.defineTypes();
 
-        log(ChatColor.WHITE + " * Starting tasks & registering components...");
+        log(ChatColor.WHITE + " * Registering components...");
         getServer().getMessenger().registerOutgoingPluginChannel(this, "BungeeCord");
         new Metrics(this, PLUGIN_ID);
         scheduler = FoliaUtil.isFolia() ? new FoliaScheduler(this) : new SpigotScheduler(this);
         BungeeUtil bungeeUtil = new BungeeUtil(this);
         userManager = new UserManager();
         Bukkit.getOnlinePlayers().forEach(userManager::get);
-
         pluginManager.registerEvents(new UserListener(userManager), this);
-        scheduler.runDelayedTimerAsync(new NpcVisibilityTask(npcRegistry, configManager), 60L, 10L);
-        skinCache = new SkinCache(configManager);
-        scheduler.runDelayedTimerAsync(new SkinCacheCleanTask(skinCache), 1200, 1200);
 
-        registerCommands();
 
         if (configManager.getConfig().checkForUpdates()) {
             UpdateChecker updateChecker = new UpdateChecker(this.getDescription());
@@ -151,6 +142,18 @@ public class ZNpcsPlus extends JavaPlugin implements ZApi {
         npcRegistry = new NpcRegistryImpl(configManager, this, packetFactory, actionRegistry);
         npcRegistry.reload();
 
+        log(ChatColor.WHITE + " * Initializing PacketEvents...");
+        packetEvents.getEventManager().registerListener(new InteractionPacketListener(userManager, npcRegistry), PacketListenerPriority.MONITOR);
+        packetEvents.init();
+
+        log(ChatColor.WHITE + " * Starting tasks...");
+        scheduler.runDelayedTimerAsync(new NpcVisibilityTask(npcRegistry, configManager), 60L, 10L);
+        skinCache = new SkinCache(configManager);
+        scheduler.runDelayedTimerAsync(new SkinCacheCleanTask(skinCache), 1200, 1200);
+
+        log(ChatColor.WHITE + " * Registering commands...");
+        registerCommands();
+
         ZApiProvider.register(this);
         enabled = true;
         log(ChatColor.WHITE + " * Loading complete! (" + (System.currentTimeMillis() - before) + "ms)");